Open
Conversation
- Adding json-schema-faker generated from VShingala/json-schema-faker pmHologation branch - The package was generatet using the command: browserify src/main.cjs.js --standalone json-schema-faker -p esmify > json-schema-faker.js
LuisTejedaS
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing json-schema-faker with another one generated through bundle from this repo:
VShingala/json-schema-faker#12
As we are using the generated Bundle from json-schema-faker, we called the file json-schema-faker-bundle.js
Correcting some unit tests due to the latest changes implemented on json-schema-fake source code
In the interest of modifying the json-schema-faker code the less, we are injecting the validation function via parameters and validation options via Json-schema-faker OptionAPI
We also removed a fix that handled "Examples" for OAS3.1 because the latest version of json-schema-faker has the support