Fix non-deterministic example generation for additionalProperties when schemaFaker is disabled#926
Open
Aggarwalmansi wants to merge 1 commit intopostmanlabs:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When converting OpenAPI schemas using
openapi-to-postmanv2, settingschemaFaker: falseis expected to produce deterministic examples.Currently, schemas that contain
additionalPropertiesstill result inrandom property names and values being generated across runs (for example,
amet_04,sit_2, etc.). This makes the output non-deterministic evenwhen schema faking is explicitly disabled.
This is most noticeable for object schemas that rely on
additionalPropertiesrather than explicitly defined fields.Root Cause
While
schemaFakeris disabled, example generation for object schemaswith
additionalPropertiesstill falls back to faker-based logic.As a result, random keys and values are produced instead of stable
schema placeholders.
Solution
This change adds a deterministic fallback for object schemas that use
additionalPropertieswhenschemaFakeris set tofalse."<property>": "<string>")is returned instead
schemaFakeris enabledadditionalPropertiesare not affectedImpact
This ensures consistent and repeatable Postman collections when
schemaFaker: falseis used, avoiding unnecessary diffs and improvingreliability in CI/CD and version-controlled workflows.
Related Issue
Fixes #854