Closed
Conversation
Author
|
This is also found in pr #184 so if you accept that then you can close this. |
Author
|
There should be however more notification fixes needed I believe that I could add here: Xavron@1d49b07 The problem is I can't remember if all of that was required not. Quite sure it was. |
Author
|
Closing this as it looks like it did get the other bits. I'm not going to care once since the other pull request has that one thing that's missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Officially putting in the fix for the following issue. I think it was an app crash without this on Android 12+
"Missing PendingIntent mutability flag More...
Inspection info:Apps targeting Android 12 and higher must specify either FLAG_IMMUTABLE or FLAG_MUTABLE when constructing a PendingIntent."