-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add ability to change background dim colour in grayscale #30391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Uncomfy
wants to merge
79
commits into
ppy:master
Choose a base branch
from
Uncomfy:background_dim_colour
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoid confusion with existing BeatmapBackground class
…ed BeatmapBackground to DimmableBeatmapBackground in BackgroundScreenBeatmap
… and DimLevel update
...for changing the dim colour. It is computed in a similar way to Drawable.DrawColourInfo
…bleBufferedContainer
Need to double-check that there is always going to be something beneath them that will have the offset.
This stops the framebuffer from being redrawn when colour changes ...which only happens because ColouredDimmableSprite needs to invalidate DrawNode together with the colour change.
…invalidation before removing Colour from invalidation
Author
|
Storyboards are now also supported storyboard.mp4However, I used default method implementation in |
Author
|
Current implementation makes performance on heavy storyboards (such as Mili - world.execute(me);) significantly worse. Mean frametimes for different parts of the map:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously discussed here: #12983
Depends on:
BufferedContainer,TextureAnimationandVideoto make it easier to inherit and tinker with osu-framework#6395BufferedContainerwithout redrawing the framebuffer osu-framework#6404getRoundedColorinto two separate parts osu-framework#6591Allows to change which colour the background is dimmed to. Currently only supports grayscale.
This is not a full implementation, as it doesn't support storyboards and videos.
The main reason I'm asking for comments so early is that this implementation handles dimming in two different classes, which leads to code duplication, so I wonder if there is a cleaner way to do this.
osu_bg_dim_colour.mp4
Here are also a few examples of how it could look with colour picker instead of a grayscale slider, using SettingsColour, but I'm unsure if it fits the design, as colour pickers weren't used in Settings/Visual Settings before. Also it doesn't work properly in Visual Settings yet, because it doesn't have a PopoverContainer in its hierarchy, and I'm not really sure how to handle it.