Make poly_use_hint destructive#1070
Merged
Merged
Conversation
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)
Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-44)
Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)
Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (200 proofs)
|
225e54b to
188e5a6
Compare
188e5a6 to
d5f0a55
Compare
hanno-becker
approved these changes
May 2, 2026
Contributor
hanno-becker
left a comment
There was a problem hiding this comment.
LGTM, thank you @mkannwischer
Rework mld_poly_use_hint, its native dispatchers, the underlying aarch64/x86_64 implementations, and the polyveck wrapper from (b, a, h) to in-place (a, h): the high bits of a are corrected in place using hint h, rather than written to a separate output buffer. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
d5f0a55 to
0253c88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework mld_poly_use_hint, its native dispatchers, the underlying
aarch64/x86_64 implementations, and the polyveck wrapper from
(b, a, h) to in-place (b, a) where b holds the hint polynomial on
entry and the corrected high bits on exit — i.e. the first output
and second input now share a buffer.
This will enable reducing memory consumption in #1007.