ACVP: Allow skipping pre-hash modes unsupported by Python's hashlib#1140
Open
mkannwischer wants to merge 2 commits into
Open
ACVP: Allow skipping pre-hash modes unsupported by Python's hashlib#1140mkannwischer wants to merge 2 commits into
mkannwischer wants to merge 2 commits into
Conversation
Some Python/OpenSSL builds lack the truncated SHA-512 variants (SHA2-512/224, SHA2-512/256) needed for pre-hash ACVP test cases. Add --skip-unsupported to drop the affected cases from both prompt and expected results; without it the client errors with guidance on the flag. Expose it through make via ACVP_OPTIONS. Resolves #719 Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Their Python 3.7 hashlib lacks sha512_224/256, so run them with ACVP_OPTIONS=--skip-unsupported instead of disabling quickcheck and acvp entirely. See #719. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (200 proofs)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Python/OpenSSL builds lack the truncated SHA-512 variants
(SHA2-512/224, SHA2-512/256) needed for pre-hash ACVP test cases. Add
--skip-unsupported to drop the affected cases from both prompt and
expected results; without it the client errors with guidance on the
flag. Expose it through make via ACVP_OPTIONS.
sha512_224in hashlib #719