mldsa: annotate functions with FIPS 204 algorithm references#1146
Open
mkannwischer wants to merge 1 commit into
Open
mldsa: annotate functions with FIPS 204 algorithm references#1146mkannwischer wants to merge 1 commit into
mkannwischer wants to merge 1 commit into
Conversation
2d88fd1 to
b155cf9
Compare
Add `@spec{Implements @[FIPS204, Algorithm N, Name]}` annotations linking
functions to their FIPS 204 algorithms.
Also normalize the existing sign.h `@spec` references from
`@[FIPS204 Algorithm N (Name)]` to the comma style used throughout.
Covers Algorithms 1-8, 16-36, 39-42, 44, 45, 48, 49. The remaining algorithms
have no dedicated function: 9-15 (IntegerToBits/.../CoeffFromHalfByte),
37/38 (HighBits/LowBits, subsumed in Decompose), 43 (BitRev8, precomputed
zetas), and 46/47 (AddVectorNTT/ScalarVectorNTT, applied inline in sign.c as
loops over AddNTT/MultiplyNTT).
- Resolves #696
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
b155cf9 to
d6f56ce
Compare
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (200 proofs)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
@spec{Implements @[FIPS204, Algorithm N, Name]}annotations linking functions to their FIPS 204 algorithms.Also normalize the existing sign.h
@specreferences from@[FIPS204 Algorithm N (Name)]to the comma style used throughout.Covers Algorithms 1-8, 16-36, 39-42, 44, 45, 48, 49. The remaining algorithms have no dedicated function: 9-15 (IntegerToBits/.../CoeffFromHalfByte), 37/38 (HighBits/LowBits, subsumed in Decompose), 43 (BitRev8, precomputed zetas), and 46/47 (AddVectorNTT/ScalarVectorNTT, applied inline in sign.c as loops over AddNTT/MultiplyNTT).
Specification:annotations linking functions to FIPS204 #696