Open
Conversation
zzjas
reviewed
Nov 6, 2023
zzjas
left a comment
zzjas
left a comment
There was a problem hiding this comment.
Other the comments in code, the fix looks ok to me and you can proceed to open a real PR. Once you open a real PR, please mark this tentative PR as Opened in your tentative_pr.csv file and also raise a PR to IDoFT marking this as Opened. Thanks!
Comment on lines
+33
to
+36
| "element1", | ||
| "attribute1", | ||
| "element2", | ||
| "attribute2" |
There was a problem hiding this comment.
I'm not sure what the style here should be, but did you check if you need an extra indentation here?
Owner
Author
There was a problem hiding this comment.
Yes there were some styling rules for this repo and the indentation is provided adhering to all those rules, otherwise the build was failing.
Comment on lines
+34
to
+45
| "stringItem", | ||
| "intItem", | ||
| "longItem", | ||
| "base64Item", | ||
| "optionalIntItem", | ||
| "optionalStringItem", | ||
| "optionalIntArrayItem", | ||
| "doubleItem", | ||
| "beanTwoItem", | ||
| "beanTwoNotRequiredItem", | ||
| "enumeration", | ||
| "enum2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the flaky tests named
testDeserializationinsideSerializationTest.javaandAttributeTest.javaclasses.cxf/rt/javascript/javascript-tests/src/test/java/org/apache/cxf/javascript/types/SerializationTest.java
Line 91 in 1a02ba3
cxf/rt/javascript/javascript-tests/src/test/java/org/apache/cxf/javascript/types/AttributeTest.java
Line 73 in 1a02ba3
Root Cause
The test
testDeserializationhas been reported as flaky when run with the NonDex tool. The tests failed because of the serialization of Testbean and AttributeTestBean classes, where the order of elements in the serialized XML changes between runs. The contents of the serialized strings do not remain constant and hence the tests are failing.Fix
To define a specific order for the XML elements when the classes TestBean1 and AttributeTestBean are serialized, we need to add the propOrder attribute to the @XmlType annotation. This attribute explicitly specifies the order in which fields should be serialized.
How this has been tested?
Java: openjdk version "11.0.20.1"
Maven: Apache Maven 3.6.3
Command used -
Command used -
Command used -
NonDex test passed after the fix.