docs(proposals): streaming token accumulation (#119)#239
Open
henschwartz wants to merge 1 commit into
Open
Conversation
|
Unsigned commits: 13fc85b. Please sign your commits. |
|
Missing Signed-off-by: 13fc85b. All commits require sign-off (via |
henschwartz
force-pushed
the
proposal/00119-streaming-token-accumulation
branch
from
13fc85b to
c319bbf
Compare
praxis-bot
reviewed
Jul 2, 2026
praxis-bot
left a comment
praxis-bot
left a comment
Collaborator
There was a problem hiding this comment.
praxis-bot review: docs(proposals): streaming token accumulation (#119)
Documentation-only PR adding a What?/Why? proposal for streaming token accumulation.
Overall Assessment
Well-written proposal with clear goals, non-goals, and motivation. Two issues found, both related to completeness.
Findings
| # | Severity | File | Description |
|---|---|---|---|
| 1 | Medium | 00119_streaming-token-accumulation.md:145 |
Missing [#119] link definition — renders as broken reference |
| 2 | Medium | 00119_streaming-token-accumulation.md:148-153 |
Relationship to existing proposal #211 deferred as open question rather than stated in the body |
henschwartz
force-pushed
the
proposal/00119-streaming-token-accumulation
branch
from
c319bbf to
faa3253
Compare
leseb
approved these changes
Jul 8, 2026
Comment on lines
+138
to
+143
| ### Stream completion signal | ||
|
|
||
| Should completion rely on the `[DONE]` sentinel, on | ||
| `end_of_stream` from the proxy, or both? Google omits `[DONE]`, | ||
| so stream close may need to be authoritative while still handling | ||
| providers that terminate with `[DONE]`. |
Contributor
There was a problem hiding this comment.
this looks more like a decision on how to do it per provider
| Some providers send running totals in intermediate chunks; others | ||
| send only the final total once. Should the accumulator always treat | ||
| the latest parsed value as authoritative (last-wins), or sum | ||
| deltas? The answer is likely per-provider and must be specified in |
Contributor
There was a problem hiding this comment.
yes it looks like a how to me :)
didierofrivia
approved these changes
Jul 8, 2026
…-proxy#119 for incremental SSE token counting so maintainers can review goals and motivation before design. Signed-off-by: Hen Schwartz <hschwart@redhat.com>
henschwartz
force-pushed
the
proposal/00119-streaming-token-accumulation
branch
from
ed55b84 to
211b2e9
Compare
Author
|
Hi @didierofrivia and @leseb I edited the PR to remove all the questions which will enter later on the "how" section |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/proposals/00119_streaming-token-accumulation.mdfor issue #119Test plan