Skip to content

Conversation

@crepi
Copy link

@crepi crepi commented Dec 15, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

We no longer require assetKey and adUnitId for in-app traffic, it can be handled with app.publisher.id with inventory mapping (like it did for web).

🧠 Rationale behind the change

We want to allow requests without ogury specific fields for assetKey/adUnitId sent for in-app. This already worked for web requests, now it's just implemented for in-app also.

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

Doc update: prebid/prebid.github.io#6371

We no longer require assetKey and adUnitId for in-app traffic,
it can be handled with app.publisher.id with inventory mapping
(like it did for web).
final ObjectNode emptyImpExt = givenEmptyImpExt();

final BidRequest bidrequest = givenBidRequest(
bidRequest -> bidRequest.app(App.builder().bundle("app_bundle").build()), // without publisher id
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants