New Bidder: Scalibur #4640

bTimor · 2025-12-21T14:31:25Z

Type of change

New bidder adapter

Description

This PR adds the Scalibur bidder adapter to Prebid Server.

Features:

Supports Banner and Video media types.
Implements User Sync via iframe.
Automated tests include standard unit tests and JSON data-driven samples.

Verification:

End-to-end user sync flow verified using a private Scalibur sync server.
Successfully verified that PBS maps the uids cookie to user.buyeruid in outgoing requests.
All tests in adapters/scalibur passed.
Root ./validate.sh passed (ignoring unrelated global config/hook test timeouts).

Checklist

I have performed a self-review of my code
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works

adapters/scalibur/scalibur.go

github-actions · 2025-12-21T14:32:11Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a87ab09

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		93.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:170:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:257:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:282:	getBidMediaType		40.0%
total:									(statements)		82.7%

github-actions · 2025-12-22T09:36:32Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c4e7220

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		40.0%
total:									(statements)		79.4%

github-actions · 2025-12-22T12:20:30Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 088c807

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		40.0%
total:									(statements)		79.4%

github-actions · 2025-12-22T12:30:58Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 60a0c74

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		37.5%
total:									(statements)		78.4%

bTimor · 2025-12-23T08:26:40Z

I've updated the media type logic to follow the recommended pattern and resolved the bot feedback. Ready for review and workflow approval.

ccorbo · 2026-01-05T20:43:40Z

adapters/scalibur/scaliburtest/success_banner.json

@@ -0,0 +1,54 @@
+{


These test files are not actually being executed, they need to be in a exemplary directory under scaliburtest.

Docs under Adapter Code Tests

https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html

ccorbo · 2026-01-05T20:45:16Z

adapters/scalibur/scalibur.go

+				// Try to extract custom fields vastXml and vastUrl from bid response
+				var bidExtData map[string]interface{}
+				if bidBytes, err := json.Marshal(bid); err == nil {
+					if err := json.Unmarshal(bidBytes, &bidExtData); err == nil {


issue: you are looking at top level bid fields here but the default vasturl field is in ext.vasturl. This needs to be aligned and pass the bid.ext instead.

ccorbo · 2026-01-05T20:48:15Z

adapters/scalibur/scalibur.go

+			impCopy.BidFloorCur = scaliburExt.BidFloorCur
+		}
+		if impCopy.BidFloorCur == "" {
+			impCopy.BidFloorCur = "USD"


question: could there be currency conversion issues if the bid floor isn't usd but you are stamping as usd bid floor?
ExtraRequestInfo has currency converter functionality

ccorbo · 2026-01-05T20:49:34Z

adapters/scalibur/scalibur.go

+func getBidMediaType(bid openrtb2.Bid, imp *openrtb2.Imp) (openrtb_ext.BidType, error) {
+	// 1 = Banner, 2 = Video, 3 = Audio, 4 = Native
+	switch bid.MType {
+	case 1:


avoid magic numbers and use constants from openrtb2 package

MarkupBanner MarkupType = 1 MarkupVideo MarkupType = 2 MarkupAudio MarkupType = 3 MarkupNative MarkupType = 4

ccorbo · 2026-01-05T20:50:53Z

static/bidder-info/scalibur.yaml

+  - banner
+  - video
+
+gvlVendorID: 1471


gvlID is registed to overwolf ltd., is that correct?

ccorbo · 2026-01-05T20:52:46Z

static/bidder-params/scalibur.json

@@ -0,0 +1,22 @@
+{


add params test file to cover this. Example: https://github.com/prebid/prebid-server/blob/master/adapters/appnexus/params_test.go

ccorbo · 2026-01-05T20:56:00Z

adapters/scalibur/scalibur.go

+
+		// Preserve GPID if present
+		var rawExt map[string]json.RawMessage
+		if err := json.Unmarshal(imp.Ext, &rawExt); err == nil {


utilize jsonutil unmarshal/marshal functions instead of standard lib json unmarshaler. eg. jsonutil.Unmarshal()

Timor Bibi added 5 commits December 1, 2025 17:34

fresh

18b45e0

fix ortb and sync server support

9806d5d

finish scalibur prebid adapter

e20d4e9

Merge remote-tracking branch 'upstream/master' into scaliburA

952745d

Add Scalibur bid adapter with Banner, Video, and User Sync support

a87ab09

github-actions bot reviewed Dec 21, 2025

View reviewed changes

adapters/scalibur/scalibur.go Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 21, 2025

View reviewed changes

adapters/scalibur/scalibur.go Outdated Show resolved Hide resolved

add ext debug

c4e7220

add gzip compression support

088c807

resolve multi type response

60a0c74

bTimor mentioned this pull request Dec 28, 2025

[Update] Add Prebid Server support for Scalibur bidder prebid/prebid.github.io#6381

Open

4 tasks

ccorbo self-assigned this Jan 5, 2026

ccorbo reviewed Jan 5, 2026

View reviewed changes

bsardo added the adapter label Jan 6, 2026

New Bidder: Scalibur #4640

Are you sure you want to change the base?

New Bidder: Scalibur #4640

Uh oh!

Conversation

bTimor commented Dec 21, 2025

Type of change

Description

Features:

Verification:

Checklist

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 21, 2025

Code coverage summary

scalibur

Uh oh!

github-actions bot commented Dec 22, 2025

Code coverage summary

scalibur

Uh oh!

github-actions bot commented Dec 22, 2025

Code coverage summary

scalibur

Uh oh!

github-actions bot commented Dec 22, 2025

Code coverage summary

scalibur

Uh oh!

bTimor commented Dec 23, 2025

Uh oh!

ccorbo Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

ccorbo Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

ccorbo Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

ccorbo Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

ccorbo Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

ccorbo Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

ccorbo Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants