Remove oudated warning about cpp and python solvers leading to different results #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianschmoll
changed the title
Contributor
Author
|
this already seems to be resolved in the master branch but i think the develop branch is depolyed here: https://precice.org/tutorials-elastic-tube-1d.html so i'm not sure if this PR is actually useful. |
MakisH
approved these changes
Jan 15, 2026
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
It's not resolved in the master branch yet. Let me know if I am overlooking something.
Contributor
Author
i think i was confused because on the original issue #195 there is a commit mentioned adressing the same thing but i could not find to which branch it was committed. Not to the correct branch i guess :D thanks for merging so quick! have a nice weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1D Elastic Tube has a warning, that the python and cpp solvers would lead to different results. The corresponding issue #195 has been closed though, so this warning can most probably be removed :)
Checklist:
changelog-entries/<PRnumber>.md.