Fix custom rules not applying under the utility project kind on gmake2#1939
Open
artemking4 wants to merge 1 commit intopremake:masterfrom
Open
Fix custom rules not applying under the utility project kind on gmake2#1939artemking4 wants to merge 1 commit intopremake:masterfrom
artemking4 wants to merge 1 commit intopremake:masterfrom
Conversation
Member
|
Can we get a test or two added here? |
Author
Dunno, i dont really know how tests here work, but im using this on my machine and its more than fine. |
13 tasks
Member
Take a look at the tests in the adjacent directory, should be pretty straight forward. |
nickclark2016
requested changes
Sep 3, 2022
Member
nickclark2016
left a comment
nickclark2016
left a comment
There was a problem hiding this comment.
Blocking until #1940 is resolved.
Jarod42
reviewed
Sep 7, 2022
| else | ||
| rules[extension] = rule | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
Can similar/copied code from gmake2_cpp.lua be factorized?
Author
There was a problem hiding this comment.
To be honest, it should be. But i dont know the right place for it to be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes utility projects not applying rules under gmake2.
Basically copied some code over from
gmake2_cpp.lua.