Skip to content

Avoid Markdown-folding in diff mode#538

Open
KSR-Yasuda wants to merge 7 commits into
preservim:masterfrom
KSR-Yasuda:feature/SkipFoldingInDiffMode
Open

Avoid Markdown-folding in diff mode#538
KSR-Yasuda wants to merge 7 commits into
preservim:masterfrom
KSR-Yasuda:feature/SkipFoldingInDiffMode

Conversation

@KSR-Yasuda

Copy link
Copy Markdown
Contributor

Fix for #427.

- To avoid Markdown-folding in diff mode
- Known issue: If any other `foldexpr` is already set precedingly, Markdown-folding is suppressed
This reverts commit 23a00a2.
@KSR-Yasuda

Copy link
Copy Markdown
Contributor Author

Off-topic: some tests do not work correctly in non-English environment?

For example, fold text result test in test/folding-toc.vader,
it expects +-- 28 lines: hello in the folding marker line, though,
Japanese environment shows +-- 28 行: hello, and the test fails.

Tried to fix it with setting $LANG, $LANGUAGE, and $LC_ALL environment variables in test/run-tests.sh,
but it did not have any effect.
I gave up.

@skoenig

skoenig commented Jun 11, 2026

Copy link
Copy Markdown

Since this PR was opened, the upstream codebase has changed, so the change can't be applied cleanly anymore.
I still encounter the diff-folding issue and would like to see it being fixed upstream.

@KSR-Yasuda

Copy link
Copy Markdown
Contributor Author

@skoenig It looks no conflict on merging into current master or commit 1bc9d0c.
Doesn't it work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants