Conversation
- Patch NumberComponent.createNumberMask to set allowLeadingZeroes: true,
preventing the mask from stripping leading zeros when a second digit is
typed (e.g. typing "07" no longer becomes "7").
- Fix createFormComponent updateValue: accept and forward flags, return the
actual changed boolean instead of always true, and only call updateOnChange
when the value has changed (matches formio base class behaviour).
- Add _onReactChange helper that passes { modified: true } when the React
component's onChange fires, so custom components correctly mark themselves
as non-pristine and show inline validation errors in real time.
- Add resolve.dedupe for react/react-dom in vite.config dev mode to prevent
duplicate React instance errors when running the example dev server.
- Add BugFixDemo to example/main.jsx to verify both fixes interactively.
Made-with: Cursor
Runs npm ci + npm run build on every PR targeting main and on pushes to main. Also verifies that the expected dist output files are present after the build so a silent vite misconfiguration cannot slip through. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch NumberComponent.createNumberMask to set allowLeadingZeroes: true, preventing the mask from stripping leading zeros when a second digit is typed (e.g. typing "07" no longer becomes "7").
Fix createFormComponent updateValue: accept and forward flags, return the actual changed boolean instead of always true, and only call updateOnChange when the value has changed (matches formio base class behaviour).
Add _onReactChange helper that passes { modified: true } when the React component's onChange fires, so custom components correctly mark themselves as non-pristine and show inline validation errors in real time.
Add resolve.dedupe for react/react-dom in vite.config dev mode to prevent duplicate React instance errors when running the example dev server.
Add BugFixDemo to example/main.jsx to verify both fixes interactively.
Made-with: Cursor