Skip to content

Changes to the plugin.py file to include the plugin remove_jar feature#116

Open
nanaessuman wants to merge 1 commit into
prestodb:masterfrom
nanaessuman:master
Open

Changes to the plugin.py file to include the plugin remove_jar feature#116
nanaessuman wants to merge 1 commit into
prestodb:masterfrom
nanaessuman:master

Conversation

@nanaessuman
Copy link
Copy Markdown

I added "remove_jar" to plugin.jar to allow users to remove jars from directories when they add files with the add_jar feature.

Comment thread prestoadmin/plugin.py
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For remove jar, there is no local path. The command should take the plugin name to remove and optionally the remote path to the plugin directory to allow for non-default configurations.

def remove_jar(plugin_name, plugin_dir=REMOTE_PLUGIN_DIR)

@rschlussel-zz
Copy link
Copy Markdown
Member

Thanks for the patch! We're excited to have a new contributor!
A couple notes on testing:
You should run 'make lint' to ensure that the code adheres to our style.
It's best to test with at least one presto node on a different node from presto-admin. Usually we write product tests to be able to run this automatically, but it's a bit complicated to set up, so it's fine if you just verify manually.

@kokosing
Copy link
Copy Markdown
Contributor

kokosing commented Mar 3, 2017

@nanaessuman Could you please address the comments from @rschlussel ? So we could merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants