Added support for expanding environment variables in configuration files.#378
Open
gorkemmulayim wants to merge 6 commits into
Open
Added support for expanding environment variables in configuration files.#378gorkemmulayim wants to merge 6 commits into
gorkemmulayim wants to merge 6 commits into
Conversation
kokosing
reviewed
Feb 20, 2019
Contributor
kokosing
left a comment
kokosing
left a comment
There was a problem hiding this comment.
There are a lot of automation failures.
| config_file = os.path.join(DIR, 'resources', 'environment_variable.properties') | ||
| conf = config.get_conf_from_properties_file(config_file) | ||
| self.assertTrue(environment_variables.called) | ||
| self.assertEqual({'a': 'environment_variable_value'}, conf) |
Contributor
There was a problem hiding this comment.
can we have an real test that is using actual environment variable, to see the configuration with expanded environment variables.
Contributor
Author
There was a problem hiding this comment.
Sorry for the late reply. I will work on this as well as automation failures.
Contributor
|
@rootG Please ping once you done with your changes. |
|
this PR seems quite old. Is anyone going to revive it? @kokosing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #329
Added support for expanding environment variables in configuration files.
For example:
Given an example node.properties files
application can now resolve variable defined by
${ENV}from environment variables.${variableName}or$variableName. In addition to this, on Windows,%variableName%definition is supported as well.