Open
Conversation
| @@ -0,0 +1,13 @@ | |||
| JASC-PAL | |||
Collaborator
There was a problem hiding this comment.
There's an existing graphics/dungeon/pal subdir, so these files could go there under graphics/dungeon/pal/b00canm/*.
| @@ -0,0 +1,74 @@ | |||
| #include "global.h" | |||
Collaborator
There was a problem hiding this comment.
If there are a ton of color files, they could go in an additional subdir under data to keep them separate from other data. Perhaps src/data/pal/* to match graphics/dungeon/pal?
| data/dungeon_sbin.o(.rodata); | ||
| data/dungeon_sbin1.o(.rodata); | ||
| src/data/b00canm.o(.rodata); | ||
| data/dungeon_sbin2.o(.rodata); |
Collaborator
There was a problem hiding this comment.
Should be fine to split up dungeon_sbin while creating all the palette files. It's the same as splitting ASM files when decompiling a particular C function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to start pulling out the AnimatedColorData from
dungeon_sbin, but I had to split it into 2 so I could git a .c file in between. For now only b00canm is extracted but I intend to run a script to extract all bXXcanm data, but before that I wanted feedback on the structure/naming/directory choices/etc, and if possible not having to splitdungeon_sbin.s