Skip to content

Comments

Introduced allowZero to control if zero values should be cleared when…#84

Open
ToreOlavKristiansen wants to merge 3 commits intoprice-format:masterfrom
ToreOlavKristiansen:allow-zero
Open

Introduced allowZero to control if zero values should be cleared when…#84
ToreOlavKristiansen wants to merge 3 commits intoprice-format:masterfrom
ToreOlavKristiansen:allow-zero

Conversation

@ToreOlavKristiansen
Copy link

… clearOnEmpty is true

This fixes the case where you want to allow empty and '0' as input field values. '0' is no longer considered empty if you raise the allowZero flag.

… clearOnEmpty is true

This fixes the case where you want to allow empty and '0' as input field values. '0' is no longer considered empty if you raise the allowZero flag.
@ToreOlavKristiansen
Copy link
Author

The codacy review failed, but I did change anything that causes it to.

@freitasmurillo
Copy link

freitasmurillo commented Mar 6, 2018

@ToreOlavKristiansen you've added the control variable allowZero to the line where Codacy found some issues. This issues already were there but as you change the code line the tools is allowed to scan this particularly stretch of code.

If you could please fix only these 3 errors related to the lines you changed. You must no pay attention to others errors.

Thank you

@ToreOlavKristiansen
Copy link
Author

@freitasmurillo Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants