Work with integer values, dont change value#88
Open
vencendor wants to merge 1 commit intoprice-format:masterfrom
Open
Work with integer values, dont change value#88vencendor wants to merge 1 commit intoprice-format:masterfrom
vencendor wants to merge 1 commit intoprice-format:masterfrom
Conversation
shadyueh
approved these changes
Jun 26, 2019
shadyueh
left a comment
shadyueh
left a comment
There was a problem hiding this comment.
This solved the boring issue when a value is a float with no cents. I updated my priceFormat with your changes and now it's handling integer values correctly. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If i have value 1000, plugin automatic change value to 10.00
If i write 1000.00 as input value all it's good
I make changes in code - if value dont have centSeparator need to add it and zeros for not lose values or make wrong changes