add DPoPProofProvider #104
Merged
+112
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a framework problem per se, but a lot of tests in applications that use PMVC expect this header to be set on test requests using RequestBuilder.
spwitt
reviewed
Dec 23, 2025
| if (locales.isEmpty()) { | ||
| // request.getLocale() returns a default locale if none are set by httpRequestConsumer but | ||
| // we still want to set to the system's default, if none were explicitly set. | ||
| locales = List.of(Locale.getDefault()); |
Contributor
There was a problem hiding this comment.
Does this work with Brady's change to the GHA test runners? Or is it a separate workaround?
Contributor
Author
There was a problem hiding this comment.
This is a merge from main of Brady's fix to pick up the default locale.
spwitt
approved these changes
Dec 23, 2025
Contributor
spwitt
left a comment
spwitt
left a comment
There was a problem hiding this comment.
Worth bumping version to something unreleased to avoid confusion? Or just another thing you'd have to keep updating on the feature branch?
Contributor
Author
I don't think it's necessary b/c PMVC doesn't get updated very often. But Brady might have other ideas. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need the ability to test DPoP proofs.
Solution
Add
to
RequestBuilderso a DPoPProofProvider can get required information and build a DPoP proof header with a constructed JWT.Not adding actual JWT building functionality to Prime at this time, but might choose to do so later.