-
Notifications
You must be signed in to change notification settings - Fork 648
Update actionlist playwright tests #7391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the ActionList Playwright snapshot tests by adding a new test for the "All Combinations" Storybook example and regenerating existing snapshot files. The PR contains no source code changes—only test configuration updates and binary snapshot file updates across multiple theme variants (light/dark modes with colorblind, tritanopia, and high-contrast themes).
Key Changes
- Added new test entry for "All Combinations" example to the test stories array
- Regenerated snapshot PNG files for existing ActionList tests across all theme combinations
Reviewed changes
Copilot reviewed 1 out of 105 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/components/ActionList.test.ts | Adds new test story entry for "All Combinations" example |
| .playwright/snapshots/components/ActionList.test.ts-snapshots/*.png | Updated/new snapshot files for visual regression testing across multiple themes |
|
Uh oh! @barmo, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
Closes #na
Changelog
New
Added existing Actionlist All Combinations example storybook to playwright tests which then also added the new snapshot files.
Motivation is so that I can add this "The everything bagel" test and show the snapshot diff with the inline description overflow fixed in another pr. The overflow fix is for this issue #https://github.com/github/memex/issues/23884
Changed
Existing Actionlist snapshot files. No source code changes in this pr. I'm assuming that the tests got outdated because previously, over 100 tests failed in this test suite.
Removed
na
Rollout strategy
I assume that updating tests do not require a release, but let me know if otherwise
Testing & Reviewing
Merge checklist
- [ ] Added/updated documentation- [ ] Added/updated previews (Storybook)- [ ] Changes are SSR compatible- [ ] Tested in Chrome- [ ] Tested in Firefox- [ ] Tested in Safari- [ ] Tested in Edge