Skip to content

Conversation

@barmo
Copy link

@barmo barmo commented Dec 29, 2025

Closes #na

Changelog

New

Added existing Actionlist All Combinations example storybook to playwright tests which then also added the new snapshot files.

Motivation is so that I can add this "The everything bagel" test and show the snapshot diff with the inline description overflow fixed in another pr. The overflow fix is for this issue #https://github.com/github/memex/issues/23884

image

Changed

Existing Actionlist snapshot files. No source code changes in this pr. I'm assuming that the tests got outdated because previously, over 100 tests failed in this test suite.

Removed

na

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why
    I assume that updating tests do not require a release, but let me know if otherwise

Testing & Reviewing

Merge checklist

  • Added/updated tests
    - [ ] Added/updated documentation
    - [ ] Added/updated previews (Storybook)
    - [ ] Changes are SSR compatible
    - [ ] Tested in Chrome
    - [ ] Tested in Firefox
    - [ ] Tested in Safari
    - [ ] Tested in Edge
  • (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)~~

@barmo barmo self-assigned this Dec 29, 2025
Copilot AI review requested due to automatic review settings December 29, 2025 20:19
@barmo barmo requested review from a team as code owners December 29, 2025 20:19
@barmo barmo requested a review from joshblack December 29, 2025 20:19
@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2025

⚠️ No Changeset found

Latest commit: 80b3031

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the ActionList Playwright snapshot tests by adding a new test for the "All Combinations" Storybook example and regenerating existing snapshot files. The PR contains no source code changes—only test configuration updates and binary snapshot file updates across multiple theme variants (light/dark modes with colorblind, tritanopia, and high-contrast themes).

Key Changes

  • Added new test entry for "All Combinations" example to the test stories array
  • Regenerated snapshot PNG files for existing ActionList tests across all theme combinations

Reviewed changes

Copilot reviewed 1 out of 105 changed files in this pull request and generated no comments.

File Description
e2e/components/ActionList.test.ts Adds new test story entry for "All Combinations" example
.playwright/snapshots/components/ActionList.test.ts-snapshots/*.png Updated/new snapshot files for visual regression testing across multiple themes

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

Uh oh! @barmo, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 17

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@github-actions github-actions bot temporarily deployed to storybook-preview-7391 December 29, 2025 20:34 Inactive
@barmo barmo added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 29, 2025
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 29, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-7391 December 29, 2025 21:16 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-7391 December 29, 2025 21:27 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-7391 December 30, 2025 15:18 Inactive
@barmo barmo changed the title Update actionlist playwright snapshot tests Update actionlist playwright tests Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants