fix: set gas floor for swaps to prevent out of gas#930
Open
owen-eth wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a 400k floor on the fastswap executor
gasLimitto prevent OOG reverts on simple single-hop routes.Why
For simple routes, Barter returns a small
GasEstimation(~70k), and the formula× 2.5 + 135k/152klands at ~310-330k — right at the median observed naturalgasUsed(316,980 across 29 on-chain samples). With the EIP-150 63/64 cascade through nested CALLs, inner calls OOG before the swap completes. Reproducedagainst revm directly (anvil
eth_simulateV1) and Tenderly archive.Why a floor (not a multiplier bump)
Distribution is bimodal: simple routes ~272-320k natural gas, multi-hop ~600-700k. Barter's estimate already scales for the larger ones — only the simple
cluster hits the cliff. Floor at 400k touches only Barter estimates ≤ ~106k; everything above is unchanged.
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review