Add tests and improve handling for tool calls and parameterless tools… #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in schemas - Added test cases for tool calls with various inputs in both Anthropics and Converses. - Improved handling of empty tool call arguments by converting them to stdClass objects. - Updated `ToolMap` and `MessageMap` to standardize the mapping of parameterless tools. - Introduced `providerToolCalls` as an empty array in text handlers for consistency.
sixlive
approved these changes
Dec 30, 2025
Contributor
sixlive
left a comment
sixlive
left a comment
There was a problem hiding this comment.
SICK!! Thanks for this. Sorry it took me so long to address!
sixlive
requested changes
Dec 30, 2025
Contributor
sixlive
left a comment
sixlive
left a comment
There was a problem hiding this comment.
Can you give me access to push to your branch there are some changes that I would like to make but I want to still give you credit for the PR
Contributor
|
Sorry, I wanted to get this merged and tagged. Closing in favor of #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in schemas
ToolMapandMessageMapto standardize the mapping of parameterless tools.providerToolCallsas an empty array in text handlers for consistency.Description
I ran into some issues (mostly mapping) due to some changes in the main Prism package not being reflected in the Bedrock package, so I went ahead and got things up to snuff.
Breaking Changes