feat(tanstack-start): add dedicated build adapter#119
Draft
tensordreams wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
commit: |
aqrln
reviewed
Jul 17, 2026
Comment on lines
+239
to
+241
| Run `vite build` first and register `nodeBuild()` in the deploy config. Never | ||
| point the single-file form at `.output/server/index.mjs`; that drops the rest | ||
| of Nitro's runnable output. |
Member
There was a problem hiding this comment.
Isn't it the whole point of Composer to run these things for you automatically? Also, why does our in-app-tree version have a dedicated tanStackStartBuild() but this version use vanilla nodeBuild()?
aqrln
marked this pull request as draft
July 17, 2026 12:59
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #118
Summary
Add a first-party TanStack Start build adapter to Composer. The authoring surface is
tanstackStart({ module, appDir }), and deploy configuration registerstanstackStartBuild()from@prisma/composer/tanstack-start/control.The control adapter reads
.output/nitro.json, requires the Nitronode-serverpreset, takes the authoritativeserverEntryfrom the manifest, and delegates the complete output-tree assembly to the existing Node directory adapter. This preserves server chunks and client/public assets without hardcoding the emitted entry path.The runnable TanStack Start example and both public guidance surfaces now use the dedicated adapter.
Testing performed
pnpm buildpnpm typecheckpnpm lintpnpm testpnpm lint:depspnpm lint:rules:symlinkspnpm check:publish-depsChecklist
git commit -s) per the DCO. The DCO status check will block merge if any commit is missing aSigned-off-by:trailer.feat,fix,chore,docs,refactor,test,build) — PR titles drive the auto-generated release notes.n/aif the change is doc-only / refactor with no behavioural delta).Notes for the reviewer
Build execution remains user-owned per ADR-0005: run
vite buildbefore deploy. The dedicated adapter interprets only the stable Nitro build manifest needed to assemble its already-built runnable output.