docs(core-model): refresh the extension-registry model to match the code#124
Open
wmadden-electric wants to merge 1 commit into
Open
docs(core-model): refresh the extension-registry model to match the code#124wmadden-electric wants to merge 1 commit into
wmadden-electric wants to merge 1 commit into
Conversation
The core-model deep dive still described a Target carrying separate
resources/services maps. The code has ExtensionDescriptor with a single
nodes registry (app-config.ts), settled by ADR-0017 (config statically
imports each extension's registry) and ADR-0031 (provisioned param values
resolve through the consumer extension's registry).
Brings the surrounding model in line with the code, grounded in
app-config.ts, deploy.ts, node.ts, and the prisma-cloud control entry:
- Target/resources/services -> ExtensionDescriptor/nodes, with the
NodeDescriptor resource|service|build union and PrismaAppConfig/defineConfig.
- Static config-import routing (ADR-0017): /control is a shipped entry, not
reserved; drop the stale ${pack}/target fromEnv() and ${build.pack}/assemble
dynamic-import story; assemblers are { kind: 'build' } registry entries.
- pack -> extension on nodes and BuildAdapter ({ extension, type, module, entry }).
- Rewrite the prismaCloud() worked instance: application.provision references
the CLI-ensured Project and returns { projectId } satisfies CloudApplication;
compute/postgres return { wiring, primitives } (LoweredResult) with the
reader-typed handoffs from ADR-0033.
- Reconcile the ADR-0003 'no config file' line with ADR-0017, which narrows it.
The ADR-0033 SPI-signature quotes were already correct on this branch and are
left as-is. Also strips two stray tool-call tags committed into ADR-0033.
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refresh the
core-model.mddeep dive so its extension-registry and lowering-SPI model matches the code. The doc still described aTargetcarrying separateresources/servicesmaps; the code hasExtensionDescriptor(packages/0-framework/1-core/core/src/app-config.ts) with a singlenodesregistry, settled by ADR-0017 (config statically imports each extension's registry) and ADR-0031 (provisioned param values resolve through the consumer extension's registry).This is the follow-up the S4 vocabulary sweep (PR #117) explicitly deferred: "The file's broader stale text is untouched (filed follow-up)."
Changes (every claim grounded in the current code)
Target/resources/services→ExtensionDescriptor/nodes, with theNodeDescriptorresource | service | buildunion,PrismaAppConfig/defineConfig, and theprovisions/application/providers/preflightfields — matchingapp-config.ts./controlis a shipped entry, not "reserved". Dropped the stale${pack}/targetfromEnv()and${build.pack}/assembledynamic-import story; assemblers are{ kind: "build" }registry entries found by(extension, type).pack→extensionon nodes andBuildAdapter({ extension, type, module, entry }), matchingnode.ts.prismaCloud()worked instance to the realExtensionDescriptor:application.provisionreferences the CLI-ensured Project and returns{ projectId } satisfies CloudApplication;compute/postgresreturn{ outputs, entities }(LoweredResult) with the reader-typed handoffs from ADR-0033, narrowingctx.applicationvia a guard.Outputs,DeployedEntity,DeployedNode,DeploymentResult { app, nodes });ReportedPrimitiveis gone.Left untouched (as scoped)
The ADR-0033 SPI-signature quotes (
ServiceLowering<P,S>,LowerContext.application: unknown) were already correct and are unchanged apart from the vocabulary rename.Incidental
Stripped two stray tool-call tags (
</content></invoke>) that had been committed into the end ofADR-0033-lowering-types-are-defined-by-their-readers.md.🤖 Generated with Claude Code