chore: remove accidentally-committed symlinks + close out FK1#1001
Merged
Conversation
Sixty-two dangling symlinks sat in the user-facing skills/ tree pointing into .agents/skills/ — a gitignored tree materialized by pnpm install, so they can never resolve in a fresh clone. They are contributor/ops skills (drive-*, ppg-*, prisma-copy-review, …) that were swept in by an over-broad `git add` during an unrelated namespaces fix (#803); skills/ is what `prisma-next init` installs into user projects, so they do not belong there at all. The two rule symlinks under .claude/rules and .cursor/rules arrived the same way (#603): those trees are gitignored presentation mirrors regenerated by `pnpm rules:sync`, never tracked. CLAUDE.md -> AGENTS.md stays: that symlink is intentional. Also drops the transient projects/fk-index-discrete-entities/ spec+plan now that FK1 (TML-3027) has shipped, per the project close-out convention. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
Contributor
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (64)
⛔ Files ignored due to path filters (2)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (64)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
size-limit report 📦
|
@prisma-next/extension-author-tools
@prisma-next/mongo-runtime
@prisma-next/family-mongo
@prisma-next/sql-runtime
@prisma-next/family-sql
@prisma-next/extension-arktype-json
@prisma-next/middleware-cache
@prisma-next/mongo
@prisma-next/extension-paradedb
@prisma-next/extension-pgvector
@prisma-next/extension-postgis
@prisma-next/postgres
@prisma-next/sql-orm-client
@prisma-next/sqlite
@prisma-next/extension-supabase
@prisma-next/target-mongo
@prisma-next/adapter-mongo
@prisma-next/driver-mongo
@prisma-next/contract
@prisma-next/utils
@prisma-next/config
@prisma-next/errors
@prisma-next/framework-components
@prisma-next/operations
@prisma-next/ts-render
@prisma-next/contract-authoring
@prisma-next/ids
@prisma-next/psl-parser
@prisma-next/psl-printer
@prisma-next/cli
@prisma-next/cli-telemetry
@prisma-next/config-loader
@prisma-next/emitter
@prisma-next/language-server
@prisma-next/migration-tools
prisma-next
@prisma-next/vite-plugin-contract-emit
@prisma-next/mongo-codec
@prisma-next/mongo-contract
@prisma-next/mongo-value
@prisma-next/mongo-contract-psl
@prisma-next/mongo-contract-ts
@prisma-next/mongo-emitter
@prisma-next/mongo-schema-ir
@prisma-next/mongo-query-ast
@prisma-next/mongo-orm
@prisma-next/mongo-query-builder
@prisma-next/mongo-lowering
@prisma-next/mongo-wire
@prisma-next/sql-contract
@prisma-next/sql-errors
@prisma-next/sql-operations
@prisma-next/sql-schema-ir
@prisma-next/sql-contract-psl
@prisma-next/sql-contract-ts
@prisma-next/sql-contract-emitter
@prisma-next/sql-lane-query-builder
@prisma-next/sql-relational-core
@prisma-next/sql-builder
@prisma-next/target-postgres
@prisma-next/target-sqlite
@prisma-next/adapter-postgres
@prisma-next/adapter-sqlite
@prisma-next/driver-postgres
@prisma-next/driver-sqlite
commit: |
wmadden
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pieces of cleanup: a pile of symlinks that should never have been committed, and the FK1 project close-out.
The symlinks
skills/carried 62 dangling symlinks pointing into.agents/skills/:They can never resolve in a fresh clone:
.agents/skills/is a gitignored tree materialized bypnpm install. And they aren't ours to ship — they're contributor/ops skills (drive-*fromprisma/ignite,ppg-*,prisma-copy-review,kernel-cve-response,querying-axiom, …) from someone's local install, sitting inskills/, which is the user-facing treeprisma-next initinstalls into user projects.git logsays they arrived in573197f25— "fix(namespaces): per-namespace typed resolution forsql.<ns>.<table>…" (#803), a namespaces bugfix. An over-broadgit addswept up the locally-materialized tree. The two rule symlinks under.claude/rules/.cursor/rulescame in the same way viaf3722c2d4(#603, "rewrite migration list"); those trees are gitignored presentation mirrors regenerated bypnpm rules:syncand are never meant to be tracked.CLAUDE.md -> AGENTS.mdis intentional and stays — it's now the only tracked symlink in the repo..claude/and.cursor/rulesare in.gitignore; gitignore simply doesn't untrack files already committed, which is why these persisted.Verified after removal:
pnpm rules:syncregenerates the rule mirrors on disk (untracked, ignored), andlint:rules:symlinks+lint:skillspass. The dangling entries never had aSKILL.md, so skill discovery already skipped them — the installed-skill set is unchanged.FK1 close-out
Drops the transient
projects/fk-index-discrete-entities/spec + plan now that FK1 (TML-3027, #989) has shipped, per the project-artifact convention inprojects/README.md.🤖 Generated with Claude Code