fix(docs): use local TypeScript compiler in package manager tabs#8086
Open
futurehua wants to merge 1 commit into
Open
fix(docs): use local TypeScript compiler in package manager tabs#8086futurehua wants to merge 1 commit into
futurehua wants to merge 1 commit into
Conversation
Signed-off-by: futurehua <futurehua@outlook.com>
|
@futurehua is attempting to deploy a commit to the Prisma Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
ChangesTypeScript command conversion
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npx tscintopnpm dlx tscoryarn dlx tsc.pnpm tscandyarn tsc.dlxconversions.Fixes #8064.
Why
The documentation installs
typescriptbefore runningtsc, butnpm-to-yarncurrently convertsnpx tsc --initto:pnpm dlx tsc --inityarn dlx tsc --initBoth
dlxcommands fetch the package namedtscfrom the registry instead of using the binary from the locally installedtypescriptpackage. That registry package is an unrelated deprecated placeholder, so the generated quickstart commands fail.The fix is applied at the shared command-conversion boundary so every npm code block containing
npx tscproduces the correct pnpm and Yarn commands.Validation
npx tsc --initpnpm tsc --inityarn tsc --initbunx tsc --initpnpm exec oxfmt --check apps/docs/source.config.tspnpm exec oxlint apps/docs/source.config.tspnpm --filter docs run types:checkSummary by CodeRabbit