chore: maintain package #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2026
Member
Author
|
TODO: Consider turning |
angeloashmore
approved these changes
Jan 13, 2026
Member
angeloashmore
left a comment
angeloashmore
left a comment
There was a problem hiding this comment.
LGTM! I left a question about an old error message, not related to the changes in this PR.
src/channel/messages.ts
Outdated
| ): ErrorResponseMessage<TError> => { | ||
| if (status < 400) { | ||
| throw new TypeError( | ||
| `Invalid error status code, expected status to be within \`[500;600[\`, got \`${status}\``, |
Member
There was a problem hiding this comment.
Should this error message contain [400, 600), not [500;600[?
Member
Since |
Co-authored-by: Angelo Ashmore <angeloashmore@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://prismic-team.slack.com/archives/CPG31MDL1/p1767962753033489
Related:
<SliceSimulator>component prismic-next#120<SliceSimulator>component prismic-vue#90<SliceSimulator>component nuxt-modules/prismic#237<SliceSimulator>component prismic-svelte#40Description
statusesCJS dependencytsdownfor building the package)Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩