This repository was archived by the owner on Sep 4, 2024. It is now read-only.
Fix issue #392 not changed value mask#393
Closed
JosielFaleiros wants to merge 2 commits intoprobil:masterfrom
Closed
Fix issue #392 not changed value mask#393JosielFaleiros wants to merge 2 commits intoprobil:masterfrom
JosielFaleiros wants to merge 2 commits intoprobil:masterfrom
Conversation
Owner
|
@JosielFaleiros |
Author
|
Hi @probil I would like to, but I am little busy these days, this will take some time, so any help from other devs for this are welcome too. Thanks for the project! |
Author
|
Hi @probil I've added a test to verify the case explained, that will be fixed by this PR. |
Owner
|
Hey @JosielFaleiros
I'm going to add this test to unit tests and will try to find a solution that handles both cases |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is to fix the problem found in the issue #392 , where the value do not get masked when the same value is pasted twice, but it should apply the mask in that case.
This code is working on a local build, and within a project where I am using this lib.
Improvement suggestions are welcome. :)