Hover state removes the gap between logo block and “Back to Editor” button#3818
Hover state removes the gap between logo block and “Back to Editor” button#3818SinhaS12 wants to merge 6 commits intoprocessing:developfrom
Conversation
|
@raclim please give a look .Thank you |
|
@SinhaS12 Can you show the before and after preview for the changes please. |
@yugalkaushik On hover now the arrow is visible and also we can see the gap between them .Thank you for waiting .
|
|
Hi @SinhaS12 I don't think we want the gap. Please see screenshot below for the current behaviour for the files tab. 
Can you update so that the gap is not present? I believe the "Back to the editor" link will also need some x-padding |
|
Hi @raclim 👋 |
|
@SinhaS12 rachel already reviewed the PR, you should update the PR with the suggestions so a final check can be done and the pr can be merged. |
|
@yugalkaushik Sir Please check it out .This is my first time open source contribution that why get so much mistake .hope it is fine now |
|
You don’t need to address me as Sir 🙂. What I’m trying to point out is that this PR also includes code from some of your other PRs. Since you’re new, you can either remove the unrelated files from this PR or open a fresh one that only contains the actual fix. Also, a small suggestion try to avoid adding very basic comments unless something is genuinely complex. |
clairep94
added
the
Contributor Follow-up Required
|
am i missing something @clairep94 |
|
Hi @SinhaS12 Please address the feedback mentioned, and when you have done so please add a demo to the PR. In the PR template we have requested all changes that impact UI require a demo screenshot or screen recording. |
3 participants
Fixes #3733
Changes:
I have verified that this pull request:
What this PR does
->Ensures nav back icon color remains visible
->Prevents opacity or theming issues
->Changes made
->Updated SCSS for nav back icon
->Forced white color visibility