Skip to content

fix: file uploader styling refactor#3983

Merged
raclim merged 2 commits intoprocessing:developfrom
runningonsideprojects:upload-files-bug-and-refactor
Mar 10, 2026
Merged

fix: file uploader styling refactor#3983
raclim merged 2 commits intoprocessing:developfrom
runningonsideprojects:upload-files-bug-and-refactor

Conversation

@runningonsideprojects
Copy link
Collaborator

@runningonsideprojects runningonsideprojects commented Mar 9, 2026

Issue:

Fixes #3914

This issue provides the following fixes / features in the file uploader:

  • changes the preview image of the file so it is proportional to the file preview container
  • implements a cleaner XML error message text display instead of the entire XHR DOM.
  • implements an onClick function on the "X" when a file fails to be uploaded that removes the specific file.

Demo:

Video showing the error message formatted properly so its just the text:

Screen.Recording.2026-03-08.at.11.00.13.PM.mov

Video showing the ability to click the "X" icon to remove a file:

Screen.Recording.2026-03-08.at.11.04.02.PM.mov

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@runningonsideprojects runningonsideprojects changed the title testing whether tests will pass fix: file uploader styling refactor Mar 9, 2026
@runningonsideprojects runningonsideprojects self-assigned this Mar 9, 2026
@ghost
Copy link

ghost commented Mar 9, 2026

HEY @runningonsideprojects OCULD YOU PLEASE GUIDE HOW TO BECOME COLLABORATOR THNAKS LOVE YOUR WOEK

@dpoppe7
Copy link

dpoppe7 commented Mar 10, 2026

HEY @runningonsideprojects OCULD YOU PLEASE GUIDE HOW TO BECOME COLLABORATOR THNAKS LOVE YOUR WOEK

Hello @Drewcoder789, thank you for your interest in contributing!
Processing foundation has different repositories you can contribute.
The contributor guidelines explain more about the contributing workflow, you can start there.
Each repository may have contributor docs within the files, which will contain detailed information about that specific repo; setting up local development, opening issues/PRs, etc. Here are the contributor docs for p5 web editor.

Hope this helps!

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this, this looks great !!!

@raclim raclim merged commit f7ddca1 into processing:develop Mar 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error interface when uploading files bug and design refactor

3 participants