add export default p5 at end of global.d.ts#8299
Merged
davepagurek merged 3 commits intoprocessing:dev-2.0from Mar 15, 2026
Merged
add export default p5 at end of global.d.ts#8299davepagurek merged 3 commits intoprocessing:dev-2.0from
export default p5 at end of global.d.ts#8299davepagurek merged 3 commits intoprocessing:dev-2.0from
Conversation
Contributor
Author
|
Also tested the fix successfully with a couple of p5 global-mode typescript projects, locally, including this non-trivial one. Process:used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8302
Changes:
adds a final
export default p5to global.d.ts when it's prepared in typescript.mjschanges one of the type tests (test/types/basic.js) to use this default import.
Prepared following @davepagurek 's instruction. (Thanks!)
PR Checklist
npm run lintpasses