Fix a bug where shared strands variables are detected in the wrong spot#8641
Merged
davepagurek merged 2 commits intodev-2.0from Mar 14, 2026
Merged
Fix a bug where shared strands variables are detected in the wrong spot#8641davepagurek merged 2 commits intodev-2.0from
davepagurek merged 2 commits intodev-2.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8640
Changes:
Basically, there was some special-casing before to make sure that varying variables correctly assigned to globals. This was causing a problem, because the global assignments were getting generated in the first hook, which is not actually the correct one in all cases. Anyway, turns out that after other updates, it seems we don't even need any of that, and we can just delete code and have my new test case pass + all of the old ones!
Live: (fixed) https://editor.p5js.org/davepagurek/sketches/mZUJxE4BY
Original (buggy, thanks @nbogie for finding it!) https://editor.p5js.org/neill0/sketches/lKYbBowtV
PR Checklist
npm run lintpasses