-
Notifications
You must be signed in to change notification settings - Fork 4
Union members upgrade fix. #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Temmmmmo
wants to merge
6
commits into
main
Choose a base branch
from
update-users
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
88f380e
Union members upgrade fix.
Temmmmmo c66c1a5
Union members upgrade fix. Linting.
Temmmmmo 252e924
Union members upgrade fix. Tests.
Temmmmmo 707bd8d
Union members upgrade fix. Fixes after review.
Temmmmmo bb7a9f3
Union members upgrade fix. Fixes after review. +Test.
Temmmmmo 01c39d6
Union members upgrade fix. Linting.
Temmmmmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ | |
|
|
||
| from print_service import __version__ | ||
| from print_service.exceptions import UnionStudentDuplicate, UserNotFound | ||
| from print_service.models import UnionMember | ||
| from print_service.models import File, PrintFact, UnionMember | ||
| from print_service.schema import BaseModel | ||
| from print_service.settings import get_settings | ||
|
|
||
|
|
@@ -90,7 +90,7 @@ def update_list( | |
| set(student_numbers) | ||
| ): | ||
| raise UnionStudentDuplicate() | ||
|
|
||
| users_id = [] | ||
| for user in input.users: | ||
| db_user: UnionMember = ( | ||
| db.session.query(UnionMember) | ||
|
|
@@ -108,21 +108,29 @@ def update_list( | |
| ) | ||
| .one_or_none() | ||
| ) | ||
|
|
||
| if db_user: | ||
| db_user.surname = user.username | ||
| db_user.union_number = user.union_number | ||
| db_user.student_number = user.student_number | ||
| else: | ||
| db.session.add( | ||
| UnionMember( | ||
| db_user := UnionMember( | ||
| surname=user.username, | ||
| union_number=user.union_number, | ||
| student_number=user.student_number, | ||
| ) | ||
| ) | ||
| db.session.flush() | ||
|
|
||
| users_id.append(db_user.id) | ||
| db_delete_users: list[UnionMember] = ( | ||
| db.session.query(UnionMember).filter(UnionMember.id.notin_(users_id)).all() | ||
| ) | ||
| for _user in db_delete_users: | ||
| for print_fact in _user.print_facts: | ||
| db.session.delete(print_fact) | ||
| for files in _user.files: | ||
| db.session.delete(files) | ||
| db.session.delete(_user) | ||
|
Comment on lines
+128
to
+133
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Мы так просрем всю статистику. Так делать нельзя
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Софт делит на юзера надо сделать |
||
| db.session.commit() | ||
| return {"status": "ok", "count": len(input.users)} | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.