Skip to content

fix(scale): reject non-decimal numeric options#802

Open
aiirvizionz wants to merge 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/scale-decimal-options
Open

fix(scale): reject non-decimal numeric options#802
aiirvizionz wants to merge 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/scale-decimal-options

Conversation

@aiirvizionz

Copy link
Copy Markdown
Contributor

Summary

  • Rejects non-decimal JavaScript numeric forms such as 1e2 and 0x10 in scale CLI numeric options
  • Keeps plain decimal integers for counts/percentages and plain decimal finite values for prices
  • Extends scale parser tests for integer, non-negative integer, and positive finite number options

Verification

  • node_modules/.bin/vitest.CMD run packages/cli/src/commands/scale.test.ts
  • node_modules/.bin/tsc.CMD -p packages/cli/tsconfig.json --noEmit
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant