Skip to content

fix(iterate): require decimal interval values #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aiirvizionz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(iterate): require decimal interval values #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/cli/src/commands/iterate-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import { InvalidArgumentError } from 'commander';

export function parsePositiveSafeInteger(value: string): number {
if (!/^\d+$/.test(value.trim())) {
throw new InvalidArgumentError('must be a positive safe integer');
}
const parsed = Number(value);
if (!Number.isSafeInteger(parsed) || parsed < 1) {
throw new InvalidArgumentError('must be a positive safe integer');
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/iterate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ describe('parsePositiveSafeInteger', () => {
expect(parsePositiveSafeInteger('60')).toBe(60);
});

it.each(['nope', '0', '-1', '1.5', 'Infinity', '9007199254740992'])(
it.each(['nope', '0', '-1', '1.5', '1e2', '0x10', 'Infinity', '9007199254740992'])(
'rejects invalid interval %s',
(value) => {
expect(() => parsePositiveSafeInteger(value)).toThrow('positive safe integer');
Expand Down
Loading