Skip to content

fix(deploy): reject non-decimal numeric options #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aiirvizionz wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

fix(deploy): reject non-decimal numeric options #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cli/src/commands/deploy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ describe('deploy numeric option parsers', () => {
expect(parsePositiveSafeInteger('4')).toBe(4);
});

it.each(['nope', '0', '-1', '1.5', 'Infinity', '9007199254740992'])(
it.each(['nope', '0', '-1', '1.5', '1e2', '0x10', 'Infinity', '9007199254740992'])(
'rejects invalid resource count %s',
(value) => {
expect(() => parsePositiveSafeInteger(value)).toThrow('positive safe integer');
Expand All @@ -18,7 +18,7 @@ describe('deploy numeric option parsers', () => {
expect(parsePositiveFiniteNumber('12.75')).toBe(12.75);
});

it.each(['nope', '0', '-1', 'NaN', 'Infinity', '-Infinity'])(
it.each(['nope', '0', '-1', '1e2', '0x10', 'NaN', 'Infinity', '-Infinity'])(
'rejects invalid finite value %s',
(value) => {
expect(() => parsePositiveFiniteNumber(value)).toThrow('positive finite number');
Expand Down
6 changes: 6 additions & 0 deletions packages/cli/src/commands/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import { Command, InvalidArgumentError } from 'commander';
import kleur from 'kleur';

export function parsePositiveSafeInteger(value: string): number {
if (!/^\d+$/.test(value)) {
throw new InvalidArgumentError('must be a positive safe integer');
}
const parsed = Number(value);
if (!Number.isSafeInteger(parsed) || parsed < 1) {
throw new InvalidArgumentError('must be a positive safe integer');
Expand All @@ -10,6 +13,9 @@ export function parsePositiveSafeInteger(value: string): number {
}

export function parsePositiveFiniteNumber(value: string): number {
if (!/^\d+(?:\.\d+)?$/.test(value)) {
throw new InvalidArgumentError('must be a positive finite number');
}
const parsed = Number(value);
if (!Number.isFinite(parsed) || parsed <= 0) {
throw new InvalidArgumentError('must be a positive finite number');
Expand Down
Loading