Skip to content

fix(merch): reject non-decimal numeric options#806

Open
aiirvizionz wants to merge 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/merch-decimal-options
Open

fix(merch): reject non-decimal numeric options#806
aiirvizionz wants to merge 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/merch-decimal-options

Conversation

@aiirvizionz

Copy link
Copy Markdown
Contributor

Summary

  • add strict parsers for merch quantity, price, markup, and budget cap options
  • reject scientific and hexadecimal numeric strings that JavaScript Number() would otherwise accept
  • add direct regression coverage for merch numeric options

Tests

  • node_modules/.bin/vitest.CMD run packages/cli/src/commands/merch.test.ts
  • node_modules/.bin/tsc.CMD -p packages/cli/tsconfig.json --noEmit
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant