Skip to content

fix: clawbackCommission wallet accounting — affiliate over-charged, seller never refunded #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
forgou37 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: clawbackCommission wallet accounting — affiliate over-charged, seller never refunded #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 78 additions & 7 deletions src/lib/affiliates/commission.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ export async function clawbackCommission(
): Promise<{ ok: boolean; error?: string }> {
const { data: conv, error } = await (admin as AnySupabase)
.from("affiliate_conversions")
.select("id, status, commission_sats, affiliate_id")
.select("id, status, commission_sats, affiliate_id, offer_id")
.eq("id", conversionId)
.single();

Expand All @@ -355,32 +355,103 @@ export async function clawbackCommission(
return { ok: false, error: "Already clawed back" };
}

// If already paid, deduct from affiliate wallet
// If already paid, reverse all three legs of the settlement:
// affiliate payout, platform fee, and seller deduction.
if (conv.status === "paid") {
const { data: wallet } = await (admin as AnySupabase)
const platformFee = calculatePlatformFee(conv.commission_sats);
const affiliatePayout = conv.commission_sats - platformFee;

// 1. Deduct affiliate payout from affiliate wallet (only what they received)
const { data: affWallet } = await (admin as AnySupabase)
.from("wallets")
.select("balance_sats")
.eq("user_id", conv.affiliate_id)
.single();

if (wallet) {
const newBalance = Math.max(0, (wallet.balance_sats ?? 0) - conv.commission_sats);
if (affWallet) {
const newAffBalance = Math.max(0, (affWallet.balance_sats ?? 0) - affiliatePayout);
await (admin as AnySupabase)
.from("wallets")
.update({ balance_sats: newBalance, updated_at: new Date().toISOString() })
.update({ balance_sats: newAffBalance, updated_at: new Date().toISOString() })
.eq("user_id", conv.affiliate_id);

await (admin as AnySupabase)
.from("wallet_transactions")
.insert({
user_id: conv.affiliate_id,
type: "affiliate_commission_clawback",
amount_sats: affiliatePayout,
balance_after: newAffBalance,
reference_id: conversionId,
status: "completed",
});
}
Comment on lines +371 to +388
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Math.max(0, ...) affiliate floor creates sats imbalance

If the affiliate's current balance is less than affiliatePayout (e.g., they already spent part of their commission), the actual deduction is clamped to whatever balance remains — but the seller is still credited the full commission_sats and the platform still loses the full platformFee. The difference (affiliatePayout - actualDeduction) appears from nowhere in the ledger. The Math.max guard was already present in the pre-bug code and may be an intentional "never go negative" policy, but the accounting imbalance it introduces on clawback is worth an explicit acknowledgment or a debt-tracking mechanism.


// 2. Return full commission to seller
const { data: offer } = await (admin as AnySupabase)
.from("affiliate_offers")
.select("seller_id")
.eq("id", conv.offer_id)
.single();

if (offer?.seller_id) {
const { data: sellerWallet } = await (admin as AnySupabase)
.from("wallets")
.select("balance_sats")
.eq("user_id", offer.seller_id)
.single();

const newSellerBalance = (sellerWallet?.balance_sats ?? 0) + conv.commission_sats;
if (sellerWallet) {
await (admin as AnySupabase)
.from("wallets")
.update({ balance_sats: newSellerBalance, updated_at: new Date().toISOString() })
.eq("user_id", offer.seller_id);
} else {
await (admin as AnySupabase)
.from("wallets")
.insert({ user_id: offer.seller_id, balance_sats: newSellerBalance });
}

await (admin as AnySupabase)
.from("wallet_transactions")
.insert({
user_id: offer.seller_id,
type: "affiliate_commission_clawback_refund",
amount_sats: conv.commission_sats,
balance_after: newBalance,
balance_after: newSellerBalance,
reference_id: conversionId,
status: "completed",
});
}
Comment on lines +397 to 426
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Silent seller-refund skip when offer is missing

If the affiliate_offers row has been deleted (or offer_id was null), offer?.seller_id evaluates to undefined and the entire seller-refund block is skipped. By the time execution reaches this check, the affiliate wallet deduction in step 1 has already been committed. The platform-fee deduction in step 3 also runs. Both are irreversible once the conversion is then stamped clawed_back, so the seller permanently loses commission_sats with no way to retry. The function should return early with an error here instead of silently skipping, to prevent the partially-applied state.


// 3. Return platform fee from platform wallet
if (platformFee > 0) {
const { data: platWallet } = await (admin as AnySupabase)
.from("wallets")
.select("balance_sats")
.eq("user_id", PLATFORM_WALLET_USER_ID)
.single();

const newPlatBalance = Math.max(0, (platWallet?.balance_sats ?? 0) - platformFee);
if (platWallet) {
await (admin as AnySupabase)
.from("wallets")
.update({ balance_sats: newPlatBalance, updated_at: new Date().toISOString() })
.eq("user_id", PLATFORM_WALLET_USER_ID);

await (admin as AnySupabase)
.from("wallet_transactions")
.insert({
user_id: PLATFORM_WALLET_USER_ID,
type: "affiliate_commission_fee_clawback",
amount_sats: platformFee,
balance_after: newPlatBalance,
reference_id: conversionId,
status: "completed",
});
}
}
Comment on lines +429 to +454
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Platform fee silently un-returned when platform wallet is absent

if (platWallet) means that if the platform wallet row does not exist at clawback time, the platformFee deduction is skipped entirely — but the seller has already been credited the full commission_sats (which includes platformFee). The result is platformFee sats created from nothing. In the forward settlement path (settleCommissions), the platform wallet is created via insert when it doesn't exist, so it will normally be present; but any edge case (DB error during original settlement, manual row deletion) leaves this path open.

}

// Update conversion status
Expand Down
Loading