FGD cleanup#36
Draft
SirYodaJedi wants to merge 7 commits into
Draft
Conversation
Used by Jack to preview animation frames (hardcoded KV name)
jjelliott
requested changes
Feb 16, 2025
jjelliott
left a comment
Contributor
There was a problem hiding this comment.
I'm fine with doing this, but I was actually thinking of deleting this as I have no interest in maintaining it anymore, so don't be surprised if it gets out of date again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some notable changes:
sequence()andskin()to Jack FGD where appropriateAddrevertedsequencevariable to defs.qc, because Jack needs it to preview animation framesStill working on fixing some syntax errors, but it's 98% done, so I figured I'd push a draft PR to get feedback. This PR is a bit messy, though, so I might need to close it and open a new one if it is to be pushed.