Merge pull request #194 from project-march/fix/remove-roslint

Removed roslint

Author: Roelemans

.travis.yml

@@ -30,7 +30,6 @@ env:
     - CATKIN_LINT=pedantic
     - CATKIN_LINT_ARGS='--ignore literal_project_name --ignore target_name_collision'
     - UPSTREAM_WORKSPACE='.rosinstall -march/march_data_collector -march/march_gait_scheduler -march/march_gain_scheduling -march/march_gait_selection -march/march_launch -march/march_safety -march/march_sound_scheduler -march/march_state_machine'
-    - AFTER_BUILD_TARGET_WORKSPACE='builder_run_build "$target_ws/install" "$target_ws" --cmake-target-skip-unavailable --cmake-target roslint'
 
 jobs:
   include:

march_hardware/CMakeLists.txt

@@ -5,7 +5,6 @@ add_compile_options(-std=c++11 -Wall -Wextra)
 
 find_package(catkin REQUIRED COMPONENTS
     roscpp
-    roslint
     soem
 )
 
@@ -15,16 +14,6 @@ catkin_package(
     LIBRARIES ${PROJECT_NAME}
 )
 
-set(ROSLINT_CPP_OPTS "--linelength=120")
-
-file(GLOB_RECURSE lintfiles
-    "include/*.h"
-    "src/*.cpp"
-)
-
-roslint_cpp(${lintfiles})
-
-
 include_directories(
     include
     SYSTEM

march_hardware/include/march_hardware/EtherCAT/EthercatMaster.h

@@ -3,7 +3,7 @@
 #define MARCH_HARDWARE_ETHERCAT_ETHERCATMASTER_H
 #include <vector>
 #include <string>
-#include <thread>  // NOLINT(build/c++11)
+#include <thread>
 
 #include <march_hardware/Joint.h>
 

march_hardware/package.xml

@@ -15,8 +15,6 @@
   <depend>roscpp</depend>
   <depend>soem</depend>
 
-  <build_depend>roslint</build_depend>
-
   <test_depend>rostest</test_depend>
   <test_depend>code_coverage</test_depend>
 </package>

march_hardware/src/EtherCAT/EthercatMaster.cpp

@@ -107,7 +107,7 @@ void EthercatMaster::ethercatSlaveInitiation()
     ec_send_processdata();
     ec_receive_processdata(EC_TIMEOUTRET);
     ec_statecheck(0, EC_STATE_OPERATIONAL, 50000);
-  } while (chk-- && (ec_slave[0].state != EC_STATE_OPERATIONAL));  // NOLINT(whitespace/braces)
+  } while (chk-- && (ec_slave[0].state != EC_STATE_OPERATIONAL));
 
   if (ec_slave[0].state == EC_STATE_OPERATIONAL)
   {

march_hardware_builder/CMakeLists.txt

@@ -7,7 +7,6 @@ find_package(catkin REQUIRED COMPONENTS
     march_hardware
     roscpp
     roslib
-    roslint
 )
 
 catkin_package(
@@ -16,16 +15,6 @@ catkin_package(
     LIBRARIES ${PROJECT_NAME}
 )
 
-set(ROSLINT_CPP_OPTS "--linelength=120")
-
-file(GLOB_RECURSE lintfiles
-    "*.cpp"
-    "*.h"
-)
-
-roslint_cpp(${lintfiles})
-
-
 include_directories(include SYSTEM ${catkin_INCLUDE_DIRS})
 
 add_library(${PROJECT_NAME}

march_hardware_builder/package.xml

@@ -15,8 +15,6 @@
   <depend>march_hardware</depend>
   <depend>yaml-cpp</depend>
 
-  <build_depend>roslint</build_depend>
-
   <test_depend>code_coverage</test_depend>
   <test_depend>rosunit</test_depend>
 </package>

march_hardware_interface/CMakeLists.txt

@@ -15,7 +15,6 @@ find_package(catkin REQUIRED COMPONENTS
     march_shared_resources
     realtime_tools
     roscpp
-    roslint
     std_msgs
     urdf
 )
@@ -93,12 +92,3 @@ if(CATKIN_ENABLE_TESTING)
         )
     endif()
 endif()
-
-set(ROSLINT_CPP_OPTS "--linelength=120")
-
-file(GLOB_RECURSE lintfiles
-    "include/*.h"
-    "src/*.cpp"
-)
-
-roslint_cpp(${lintfiles})

march_hardware_interface/package.xml

@@ -24,8 +24,6 @@
   <depend>march_hardware</depend>
   <depend>march_hardware_builder</depend>
 
-  <build_depend>roslint</build_depend>
-
   <exec_depend>robot_state_publisher</exec_depend>
   <exec_depend>xacro</exec_depend>
   <exec_depend>ethercat_grant</exec_depend>

march_imu_manager/CMakeLists.txt

@@ -5,7 +5,6 @@ add_compile_options(-std=c++11 -Wall -Wextra)
 
 find_package(catkin REQUIRED COMPONENTS
     roscpp
-    roslint
     sensor_msgs
 )
 
@@ -23,14 +22,6 @@ include_directories(
     ${catkin_INCLUDE_DIRS}
 )
 
-file(GLOB_RECURSE lintfiles
-    "src/*.cpp"
-    "src/*.h"
-    "test/*.cpp"
-)
-
-roslint_cpp(${lintfiles})
-
 set(xsensdeviceapi_LOCATION ${PROJECT_SOURCE_DIR}/lib/libxsensdeviceapi.so)
 set(xstypes_LOCATION ${PROJECT_SOURCE_DIR}/lib/libxstypes.so)