Remove SOIL2, use stb_image directly #963
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't using any of the features SOIL2 provides, so it was basically a wrapper around
stb_image. Since SOIL2 pulls in its own set of OpenGL functions, this conflicted with the efforts to use GLAD or user-provided GL function pointers.This PR addresses the issue by removing SOIL2 and loading textures directly via stb_image, using the GL calls in the
Textureclass.