Update documentation and code to follow coding convention#733
Merged
Mzack9999 merged 1 commit intoprojectdiscovery:devfrom Sep 15, 2025
Merged
Update documentation and code to follow coding convention#733Mzack9999 merged 1 commit intoprojectdiscovery:devfrom
Mzack9999 merged 1 commit intoprojectdiscovery:devfrom
Conversation
mjkim610
changed the title
ProjectDiscovery code usually follows the rule "Words in names that are initialisms or acronyms (e.g., URL and NATO) should have the same case." (defined in https://google.github.io/styleguide/ go/decisions.html#initialisms) SOCKS5 is most commonly written in all-caps, just like HTTP. This commit updates the documentation and code to all use the same style when refering to SOCKS5 as well as adhere to the coding convention. This commit also updates some other style errors. Signed-off-by: MJ Kim <mjkim610@gmail.com>
Mzack9999
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProjectDiscovery code usually follows the rule "Words in names that are initialisms or acronyms (e.g., URL and NATO) should have the same case." (defined in https://google.github.io/styleguide/go/decisions.html#initialisms) SOCKS5 is most commonly written in all-caps, just like HTTP.
This commit updates the documentation and code to all use the same style when refering to SOCKS5 as well as adhere to the coding convention. This commit also updates some other style errors.
Proposed changes
Checklist