Add documentation for using metrics in health checks#744
Open
gianlucam76 wants to merge 1 commit into
Open
Conversation
egrosdou01
requested changes
May 30, 2026
Contributor
egrosdou01
left a comment
egrosdou01
left a comment
There was a problem hiding this comment.
Only minor changes. The context and examples look clean.
| Each check can: | ||
|
|
||
| Lua's scripting capabilities offer flexibility in defining complex validation logic tailored to specific add-ons or applications. | ||
| - **Inspect Kubernetes resources** — fetch objects by Group/Version/Kind and evaluate them with a Lua script or CEL rules. |
Contributor
There was a problem hiding this comment.
Can we keep the same format for listing items?
-Property Name: The description
Member
Author
There was a problem hiding this comment.
The problem is there is no single field for each of above. It is the entire validateHealth structure (group, version, kind) to select resources. Then the same "script" can contain Lua to evaluate either resources or metrics or both.
| When the Prometheus endpoint requires a bearer token, first create the Secret: | ||
|
|
||
| ```bash | ||
| kubectl create secret generic prometheus-token \ |
Contributor
There was a problem hiding this comment.
Same command outline format starting with $
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.