Skip to content

Update test to sleep 0.5s between component new and component delete #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update test to sleep 0.5s between component new and component delete #1368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ca7d7e
Add more assertions in `component new` then `component delete` test
simu May 15, 2026
6d164b5
Sleep 0.5s between `component new` and `component delete`
simu May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions tests/test_component_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

import click
import pytest
import time
import shutil
import yaml
from pathlib import Path as P
Expand Down Expand Up @@ -851,6 +852,20 @@ def test_run_component_new_then_delete(tmp_path: P, cli_runner: RunnerFunc):
["-d", tmp_path, "-vvv", "component", "new", component_name, "--lib", "--pp"]
)
assert result.exit_code == 0
assert (tmp_path / "dependencies" / component_name).exists()
assert (
tmp_path
/ "dependencies"
/ f".repos/github.com/projectsyn/component-{component_name}.git"
).exists()

# NOTE(sg): This test is flaky without this sleep because something continues to create files in
# the component's Git repo directory after the `cli_runner()` call for `component create`
# returns. After some testing, we've settled on 0.5s sleep which is enough to not see a single
# failure in approx 8000 back-to-back runs. Using `subprocess.call()` instead of the click
# `CliRunner` seems to also fix (or hide) the issue, but two `subprocess.call()` are actually
# slower than sleeping here.
time.sleep(0.5)

result = cli_runner(
["-d", tmp_path, "-vvv", "component", "delete", "--force", component_name]
Expand All @@ -859,6 +874,11 @@ def test_run_component_new_then_delete(tmp_path: P, cli_runner: RunnerFunc):

# Ensure the dependencies folder is gone.
assert not (tmp_path / "dependencies" / component_name).exists()
assert not (
tmp_path
/ "dependencies"
/ f".repos/github.com/projectsyn/component-{component_name}.git"
).exists()

# Links in the inventory should be gone too.
for f in [
Expand Down
Loading