fix: use maven release type for release-please#1967
Merged
zeitlinger merged 4 commits intomainfrom Mar 19, 2026
Merged
Conversation
This reverts commit c77112b. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
The previous `java` release type only updates CHANGELOG.md and the manifest, leaving pom.xml files with -SNAPSHOT versions at the tagged commit. This caused the v1.6.0 deploy to fail with a 405 when Maven tried to upload snapshots to Central. The `maven` release type auto-discovers all pom.xml files and updates their versions in the release commit, making the build-release script's version manipulation unnecessary. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
The 1.6.0-SNAPSHOT bump was done manually before release-please was configured with the maven release type. Now that release-please will handle pom.xml version updates, reset to 1.5.0-SNAPSHOT so the next release PR sets them to 1.6.0 correctly. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
zeitlinger
force-pushed
the
fix/revert-release-and-fix-config
branch
from
ac7d597 to
2392204
Compare
Member
Author
|
@jaydeluca can you take a look? |
jaydeluca
approved these changes
Mar 19, 2026
Merged
zeitlinger
added a commit
that referenced
this pull request
Mar 19, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>1.5.1</summary> ## [1.5.1](v1.5.0...v1.5.1) (2026-03-19) ### Bug Fixes * **deps:** update dependency io.prometheus:prometheus-metrics-bom to v1.5.0 ([#1877](#1877)) ([043fc57](043fc57)) * **deps:** update dependency org.springframework.boot:spring-boot-starter-parent to v4.0.3 ([#1900](#1900)) ([0d800d0](0d800d0)) * **deps:** update jetty monorepo to v12.1.7 ([#1932](#1932)) ([5bd3b79](5bd3b79)) * **deps:** update junit-framework monorepo to v6.0.3 ([#1880](#1880)) ([05ad751](05ad751)) * exclude standalone examples from `mise run format` ([#1931](#1931)) ([537fb88](537fb88)) * Handle empty datapoints in otel exporter ([#1898](#1898)) ([59c8552](59c8552)) * inline set-version logic in build-release.sh ([#1884](#1884)) ([c050435](c050435)) * reduce lychee retries to avoid compounding GitHub 429s ([#1940](#1940)) ([cc17d6e](cc17d6e)) * remove version manipulation from build-release.sh ([#1886](#1886)) ([93e2b6d](93e2b6d)) * trigger Maven deploy on release-please published events ([#1966](#1966)) ([643d0e7](643d0e7)) * use /tree/ instead of /blob/ for directory URL ([#1944](#1944)) ([b81332e](b81332e)) * use maven release type for release-please ([#1967](#1967)) ([ff3bd2d](ff3bd2d)) ### Documentation * document DCO sign-off requirement for contributions ([#1937](#1937)) ([0860e77](0860e77)) </details> --- > [!IMPORTANT] > Close and reopen this PR to trigger CI checks. --------- Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy failed — pom.xml files still had
-SNAPSHOTversionsrelease-typefromjavatomavenin the release-pleaseconfig so it auto-discovers and updates all
pom.xmlversions in therelease commit
prometheus-metrics-parent/pom.xmlfromextra-filessincethe maven strategy handles it automatically
The
javarelease type only updates CHANGELOG and the manifest. Themaventype does XML-aware pom.xml version updates, which is what weneed.
The v1.6.0 tag and GitHub release have already been deleted.
Test plan
pom.xml version updates