fix: stabilize flaky timer and thread count tests#1973
Open
zeitlinger wants to merge 1 commit intomainfrom
Open
fix: stabilize flaky timer and thread count tests#1973zeitlinger wants to merge 1 commit intomainfrom
zeitlinger wants to merge 1 commit intomainfrom
Conversation
GaugeTest.testTimer: Thread.sleep(12) can take 100ms+ on CI due to scheduling delays. Assert only that the timer measured > 10ms, not that it's close to exactly 12ms. JvmThreadsMetricsTest.testInvalidThreadIds: background threads can start between scrapes, changing counts for arbitrary states. Assert only that the UNKNOWN count increased by the expected amount. Fixes #1971, fixes #1972 Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thread.sleep(12)can take 100ms+ on CI.Assert
> 10msinstead ofcloseTo(12ms, 5ms)can start between scrapes. Assert only that UNKNOWN count increased
by the expected amount, ignore other states
Fixes #1971, fixes #1972
Test plan
mise run buildpasses