Closed
Conversation
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
jaydeluca
changed the title
zeitlinger
added a commit
that referenced
this pull request
Mar 20, 2026
Add group-pull-request-title-pattern with ${version} so release-please
can match the merged PR and create the GitHub release. The default
group title is "chore: release main" which lacks the version, causing
release-please to skip release creation on merge.
Also:
- Add issues: write permission (from #1975)
- Remove separate-pull-requests: false (already the default)
- Remove redundant extra-files (maven type auto-discovers pom.xml)
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
3 tasks
Member
|
Thanks - added into #1978 |
zeitlinger
added a commit
that referenced
this pull request
Mar 20, 2026
## Summary
- Add `group-pull-request-title-pattern` with `${version}` so
release-please can match the merged PR and create the GitHub release.
The default group title is `chore: release main` which lacks the
version, preventing release creation on merge.
- Add `issues: write` permission (incorporates #1975)
- Remove `separate-pull-requests: false` (already the default)
- Remove redundant `extra-files` (maven type auto-discovers pom.xml)
Supersedes #1975
## Test plan
- [ ] CI passes
- [ ] After merge, release-please creates PR with title like
`chore(main): release 1.5.1`
- [ ] Merging that PR creates v1.5.1 tag and GitHub release
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hoping that fixing the missing
issuespermission will result in us getting an issue with some diagnostic info if something is failing.Also moved the release type into the action config, not sure if that matters. I know it's in the other config file too
referenced: https://github.com/googleapis/release-please-action#basic-configuration