Skip to content

Fix escaping for non-string label values #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
happykawayigt wants to merge 1 commit into from
+24 −1
Closed

Fix escaping for non-string label values #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/registry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ function flattenSharedLabels(labels) {
}
function escapeLabelValue(str) {
if (typeof str !== 'string') {
return str;
str = String(str);
}
return escapeString(str).replace(/"/g, '\\"');
}
Expand Down
23 changes: 23 additions & 0 deletions test/registerTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,29 @@ describe('Register', () => {
expect(escapedResult).toMatch(/\\"/);
});

it('should stringify and escape non-string label values', async () => {
register.registerMetric({
async get() {
return {
name: 'test_metric',
type: 'counter',
help: 'A test metric',
values: [
{
value: 12,
labels: {
label: ['say "hi"\nand \\back'],
},
},
],
};
},
});

const escapedResult = await register.metrics();
expect(escapedResult).toContain('label="say \\"hi\\"\\nand \\\\back"');
});

describe('should output metrics as JSON', () => {
it('should output metrics as JSON', async () => {
register.registerMetric(getMetric());
Expand Down
Loading